1e0a1308bf
The cleanup `trap 'rm -rf "$TMP"' EXIT` referenced a `local TMP` from
inside cmd_sync(). EXIT traps fire when the shell exits, not when the
function returns — by then the function-local was out of scope, and
set -u exploded the trap body with "TMP: unbound variable", which
masked the script's true exit status with 1.
The install/upgrade work itself completed before the trap ran (so it
looked cosmetic), but the non-zero exit broke automated wrappers and
cron jobs that check $?.
Two changes, both small:
1. Drop `local` so TMP persists at script scope through the EXIT
trap.
2. Use `${TMP:-}` in the trap body so any future regression that
tightens TMP's scope (or adds a code path where TMP is never
assigned) doesn't re-introduce the same explosion.
Verified with `bash -c 'set -euo pipefail; foo() { local TMP;
TMP=$(mktemp -d); trap "rm -rf \$TMP" EXIT; }; foo'` → reproduces
the original error; the patched form is silent and exits 0.
6.8 KiB
Executable File
6.8 KiB
Executable File