The cleanup `trap 'rm -rf "$TMP"' EXIT` referenced a `local TMP` from
inside cmd_sync(). EXIT traps fire when the shell exits, not when the
function returns — by then the function-local was out of scope, and
set -u exploded the trap body with "TMP: unbound variable", which
masked the script's true exit status with 1.
The install/upgrade work itself completed before the trap ran (so it
looked cosmetic), but the non-zero exit broke automated wrappers and
cron jobs that check $?.
Two changes, both small:
1. Drop `local` so TMP persists at script scope through the EXIT
trap.
2. Use `${TMP:-}` in the trap body so any future regression that
tightens TMP's scope (or adds a code path where TMP is never
assigned) doesn't re-introduce the same explosion.
Verified with `bash -c 'set -euo pipefail; foo() { local TMP;
TMP=$(mktemp -d); trap "rm -rf \$TMP" EXIT; }; foo'` → reproduces
the original error; the patched form is silent and exits 0.
Single-file POSIX bash script with three subcommands:
install First-time install. Refuses to overwrite an existing one.
upgrade Refresh existing install. Refuses if nothing's installed yet.
check Report installed version vs latest. No changes. Exit 0/1/2
for current/outdated/not-installed (handy for cron-driven
update monitoring).
Solves the long-standing "module installed but invisible in WHMCS" trap:
when admins ran the documented `git clone | rsync` recipe as root, the
new files landed as root:root and the WHMCS web user couldn't read
them. The script reads the parent dir's owner via `stat -c '%U:%G'` and
applies it via rsync `--chown`, so a `sudo bash` install ends up with
correct ownership automatically.
Other niceties:
- --version v1.4.1 pin a specific tag (default: latest published)
- --with-addon also sync modules/addons/VirtFusionDns
- Backs up + restores config/ConfigOptionMapping.php across the
rsync --delete (the old docs warned about this; the script just
handles it).
- Writes .installed-version marker so `check` can report current state.
- Pipeable via curl OR wget — both forms documented in the script
header for ad-hoc piped invocations.
