EZSCALE/virtfusion-whmcs-module
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 10 Wiki Activity

fix: TestConnection for unsaved servers, traffic display, and cache-busting

Browse Source 
- Use $params['serverhostname']/serverpassword directly in TestConnection
  instead of database lookup (serverid=0 is falsy for new servers)
- Default traffic "Used" to 0 GB when allocated but no usage reported
- Add ?v=0.0.19 cache-busting to JS/CSS includes in overview.tpl

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
EZSCALE
2026-02-07 14:51:58 -06:00
parent 1e471affd0
commit e8d2eb0aa1
4 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@@ -52,6 +52,9 @@ All notable changes to the VirtFusion Direct Provisioning Module for WHMCS.
- Change `catch(Exception)` to `catch(Throwable)` in hooks.php for PHP 8.0+ compatibility - Change `catch(Exception)` to `catch(Throwable)` in hooks.php for PHP 8.0+ compatibility
- Open VNC window before AJAX call to avoid popup blocker - Open VNC window before AJAX call to avoid popup blocker
- Memory conversion checks key name instead of display name - Memory conversion checks key name instead of display name
- Fix TestConnection failing for new/unsaved servers — use `$params` directly instead of database lookup (serverid=0 is falsy)
- Fix traffic "Used" showing `-` instead of `0 GB` when traffic is allocated but no usage reported yet
- Add cache-busting `?v=0.0.19` to JS/CSS includes in overview.tpl to prevent stale browser cache
### Removed ### Removed
- Firewall feature (non-functional — rulesets must be created in VirtFusion admin panel) - Firewall feature (non-functional — rulesets must be created in VirtFusion admin panel)

16
modules/servers/VirtFusionDirect/VirtFusionDirect.php
View File

@@ -70,15 +70,17 @@ function VirtFusionDirect_ConfigOptions()
function VirtFusionDirect_TestConnection(array $params) function VirtFusionDirect_TestConnection(array $params)
{ {
try { try {
$module = new Module(); $hostname = trim($params['serverhostname'] ?? '');
$cp = $module->getCP($params['serverid']); $password = $params['serverpassword'] ?? '';
if (!$cp) { if (empty($hostname) || empty($password)) {
return ['success' => false, 'error' => 'Unable to retrieve server configuration. Please verify the server hostname and access hash/password.']; return ['success' => false, 'error' => 'Server hostname and password are required. Please verify the server configuration.'];
} }
$request = $module->initCurl($cp['token']); $url = 'https://' . $hostname . '/api/v1';
$data = $request->get($cp['url'] . '/connect'); $module = new Module();
$request = $module->initCurl($password);
$data = $request->get($url . '/connect');
$httpCode = $request->getRequestInfo('http_code'); $httpCode = $request->getRequestInfo('http_code');
@@ -96,7 +98,7 @@ function VirtFusionDirect_TestConnection(array $params)
} }
return ['success' => false, 'error' => 'Unexpected response from VirtFusion API (HTTP ' . $httpCode . '). Please check the server configuration.']; return ['success' => false, 'error' => 'Unexpected response from VirtFusion API (HTTP ' . $httpCode . '). Please check the server configuration.'];
} catch (\Exception $e) { } catch (\Throwable $e) {
return ['success' => false, 'error' => 'Connection test failed: ' . $e->getMessage()]; return ['success' => false, 'error' => 'Connection test failed: ' . $e->getMessage()];
} }
} }

2
modules/servers/VirtFusionDirect/lib/ServerResource.php
View File

@@ -21,6 +21,8 @@ class ServerResource
$trafficUsed = '-'; $trafficUsed = '-';
if (isset($server['usage']['traffic']['used'])) { if (isset($server['usage']['traffic']['used'])) {
$trafficUsed = round($server['usage']['traffic']['used'] / 1073741824, 2) . ' GB'; $trafficUsed = round($server['usage']['traffic']['used'] / 1073741824, 2) . ' GB';
} elseif (isset($server['settings']['resources']['traffic']) && $server['settings']['resources']['traffic'] > 0) {
$trafficUsed = '0 GB';
} }
$data = [ $data = [

4
modules/servers/VirtFusionDirect/templates/overview.tpl
View File

@@ -1,5 +1,5 @@
<link href="{$systemURL}modules/servers/VirtFusionDirect/templates/css/module.css" rel="stylesheet"> <link href="{$systemURL}modules/servers/VirtFusionDirect/templates/css/module.css?v=0.0.19" rel="stylesheet">
<script src="{$systemURL}modules/servers/VirtFusionDirect/templates/js/module.js"></script> <script src="{$systemURL}modules/servers/VirtFusionDirect/templates/js/module.js?v=0.0.19"></script>
{if $serviceStatus eq 'Active'} {if $serviceStatus eq 'Active'}